Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Photo gallery with DevConfCZ2020 pictures #450

Closed
wants to merge 2 commits into from
Closed

Photo gallery with DevConfCZ2020 pictures #450

wants to merge 2 commits into from

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Jan 28, 2020 •
edited
Loading

What this PR does / why we need it:

Show DevConf.cz KubeVirt presence

Does this PR fix any issue? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Special notes for your reviewer:

Article preview at: https://deploy-preview-450--kubevirtio.netlify.com/galleries/2020-01-31-devconfcz2020-in-pictures

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 28, 2020
@kubevirt-bot kubevirt-bot added kind/blog Label for blog entries kind/website Label for web site management/maintenance/... size/M labels Jan 28, 2020
@iranzo iranzo mentioned this pull request Feb 3, 2020
Merged
@codificat
Copy link
Contributor

/hold
until we have some content

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@ptrnull
Copy link
Contributor

ptrnull commented Feb 27, 2020

@codificat we don't need content to publish the photo gallery, do we?

@iranzo
Photo gallery with DevConfCZ2020 pictures
73e1003 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@fabiand
Copy link
Member

fabiand commented Apr 16, 2020

@codificat can you or somebody review and merge this pr?

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2020
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2020
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2020
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 2, 2020
@kubevirt-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 95a6e09 Merge branch 'source' into article-devconfinpictures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hroyrh
You can assign the PR to them by writing /assign @hroyrh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mazzystr mazzystr mentioned this pull request Nov 3, 2020
Merged
@mazzystr
Copy link
Contributor

mazzystr commented Nov 3, 2020

This is not going to be easily mergeable since we don't hear from Iranzo much anymore. Closing.

@mazzystr mazzystr closed this Nov 3, 2020
@iranzo
Copy link
Contributor Author

iranzo commented Nov 3, 2020

This is not going to be easily mergeable since we don't hear from Iranzo much anymore. Closing.

This was ready in January, you can easily get this rebased and updated so that in can be mergeable again.

Regards

@mazzystr
Copy link
Contributor

mazzystr commented Nov 3, 2020

/reopen

@kubevirt-bot
Copy link
Contributor

@mazzystr: Failed to re-open PR: state cannot be changed. The repository that submitted this pull request has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mazzystr
Copy link
Contributor

mazzystr commented Nov 3, 2020

@iranzo Not sure what happened here. Your fork seems to have disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codificat codificat codificat left review comments

@ptrnull ptrnull Awaiting requested review from ptrnull

Assignees
No one assigned
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/blog Label for blog entries kind/website Label for web site management/maintenance/... lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iranzo @codificat @ptrnull @fabiand @kubevirt-bot @mazzystr